fix(worker): digest by key #7569
Conversation
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
djabarovgeorge
temporarily deployed
to
Linting
GitHub Actions
Inactive
There was a problem hiding this comment.
revert the removal of digest key in Dashboard.
| @@ -252,18 +253,22 @@ export class JobRepository extends BaseRepository<JobDBModel, JobEntity, Enforce | |||
| }; | |||
| } | |||
|
|
|||
| private buildDigestQuery(digestKey: string | undefined, digestValue: string | number | undefined) { | |||
| const digestQueryV1 = digestKey ? { [`payload.${digestKey}`]: digestValue } : null; | |||
There was a problem hiding this comment.
In v1, we handled digest aggregation by:
- Extracting a value from the job payload using a specified digest key
- Checking if another job already existed with the same digest key-value pair
- If a match was found, we would merge the new job with the existing one, otherwise create new one.
| private buildDigestQuery(digestKey: string | undefined, digestValue: string | number | undefined) { | ||
| const digestQueryV1 = digestKey ? { [`payload.${digestKey}`]: digestValue } : null; | ||
| // Digest key parsing is handled by the framework, leaving only the digest value available here | ||
| const digestQueryV2 = !digestKey && digestValue ? { [`digest.digestValue`]: digestValue } : null; |
There was a problem hiding this comment.
now we store the final digest value directly. We don't track how this value was generated - we simply check if this exact digest value already exists in our system.
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -278,7 +280,7 @@ export class AddJob { | |||
| { | |||
| $set: { | |||
| 'digest.type': metadata.type, | |||
| 'digest.digestKey': metadata.digestKey, | |||
| 'digest.digestValue': metadata.digestValue, | |||
There was a problem hiding this comment.
Any backwards compatability concerns?
There was a problem hiding this comment.
nvm, saw it later in the query builder
There was a problem hiding this comment.
yeah this part is about the framework digest key, which was not working before.
and in the query builder we created a clear separation of the 2 versions, so it would be clear there as well.
| return `${resource}:digestKey:${digestKey}:digestValue:${digestValue}`; | ||
| } | ||
|
|
||
| if (digestValue) { |
There was a problem hiding this comment.
What's the scenario where we have a key but not a digestValue? Is the key only the fixed subscriberId?
There was a problem hiding this comment.
sorry i missed this one before merging.
in v2 in the end there is no digestKey only parsed key which is the digestValue, so if digestValue is missing we will use dynamic subscriberId
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer